[CHAT-523] Always rephrase question for Sonnet 4.5#1079
Merged
Conversation
davidgisbey
force-pushed
the
523-always-rephrase-question
branch
from
5ce9291 to
682935a
Compare
davidgisbey
force-pushed
the
523-always-rephrase-question
branch
from
682935a to
8c92594
Compare
davidgisbey
force-pushed
the
523-always-rephrase-question
branch
from
8c92594 to
75c951c
Compare
davidgisbey
force-pushed
the
523-always-rephrase-question
branch
2 times, most recently
from
86afd96 to
a44f3c6
Compare
davidgisbey
changed the title
davidgisbey
force-pushed
the
523-always-rephrase-question
branch
2 times, most recently
from
8b957fe to
e48cff4
Compare
davidgisbey
force-pushed
the
523-always-rephrase-question
branch
from
e48cff4 to
61aa1ac
Compare
Contributor
Author
|
We're going to hold off on this until later next week due to a suspected increase of surge in traffic in the next week. |
We want to update the QuestionRephraser to always rephrase the question, even if it is the users first question. This updates the QuestionRephraser to do this for all models except Sonnet 4.0 as we don't have updated prompts for that model so it should continue to use the existing implementation. We've also got a slight change due to always rephrasing, in that we need two user prompts. One for when there is history, and one for when there isn't. I've added some basic tests to check that the correct system prompt is being used in both situations.
davidgisbey
force-pushed
the
523-always-rephrase-question
branch
from
61aa1ac to
bdc3493
Compare
davidgisbey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until sign off from DS. Likely w/c 18/05
Description
We want to update the QuestionRephraser to always rephrase the question, even if it is the users first question.
This updates the QuestionRephraser to do this for all models except Sonnet 4.0 as we don't have updated prompts for that model so it should continue to use the existing implementation.
We've also got a slight change due to always rephrasing, in that we need two user prompts. One for when there is history, and one for when there isn't.
I've added some basic tests to check that the correct user prompt is being used in both situations.
Jira ticket
https://gdsgovukagents.atlassian.net/jira/software/c/projects/CHAT/boards/269?label=Backend_Dev&selectedIssue=CHAT-523